Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable SO_REUSEPORT in listener config #1936

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Enables SO_REUSEPORT which allows multiple sockets to bind to the same address and port - this is useful when the auth service needs to be restarted and the port is still being held by a reverse proxy (i.e. envoy) until all the connections are drained

@kangmingtay kangmingtay requested a review from a team as a code owner February 6, 2025 08:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13175071465

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.145%

Totals Coverage Status
Change from base Build 13158754064: 0.0%
Covered Lines: 9980
Relevant Lines: 15088

💛 - Coveralls

Copy link
Contributor

@hf hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this can cause us problems but hopefully solve some.

@kangmingtay kangmingtay merged commit a474b80 into master Feb 7, 2025
4 checks passed
@kangmingtay kangmingtay deleted the km/fix-serve branch February 7, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants